Thanks to visit codestin.com
Credit goes to github.com

Skip to content

6387 update_kwargs for merging multiple configs#7109

Merged
wyli merged 9 commits into
Project-MONAI:devfrom
wyli:6387-merge-args
Oct 10, 2023
Merged

6387 update_kwargs for merging multiple configs#7109
wyli merged 9 commits into
Project-MONAI:devfrom
wyli:6387-merge-args

Conversation

@wyli

@wyli wyli commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

Fixes #6387
Fixes #5899

Description

  • add api for update_kwargs
  • add support of merging multiple configs files and dictionaries
  • remove warning message of directory in runtests.sh

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits October 10, 2023 13:33
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from KumoLiu, Nic-Ma and ericspod October 10, 2023 12:49
Comment thread monai/bundle/scripts.py

@ericspod ericspod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyli

wyli commented Oct 10, 2023

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: Wenqi Li <[email protected]>
@wyli

wyli commented Oct 10, 2023

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: Wenqi Li <[email protected]>
@wyli

wyli commented Oct 10, 2023

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) October 10, 2023 19:29
Signed-off-by: Wenqi Li <[email protected]>
@wyli

wyli commented Oct 10, 2023

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli merged commit 8d730cd into Project-MONAI:dev Oct 10, 2023
@wyli wyli deleted the 6387-merge-args branch October 10, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APIs for combining file-based and dict-based configs Merging/overriding configs with same format in monai bundle run

3 participants