Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow ApplyTransformToPointsd receive a sequence of refer keys#8063

Merged
KumoLiu merged 14 commits into
Project-MONAI:devfrom
KumoLiu:enhance-applypoints
Sep 4, 2024
Merged

Allow ApplyTransformToPointsd receive a sequence of refer keys#8063
KumoLiu merged 14 commits into
Project-MONAI:devfrom
KumoLiu:enhance-applypoints

Conversation

@KumoLiu

@KumoLiu KumoLiu commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Enhance ApplyTransformToPointsd to receive a sequence of refer keys.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu

KumoLiu commented Sep 2, 2024

Copy link
Copy Markdown
Contributor Author

refer to the use case here: https://github.com/Project-MONAI/tutorials/blob/main/3d_registration/learn2reg_nlst_paired_lung_ct.ipynb
enhance ApplyTransformToPointsd to receive a sequence of refer keys.

Comment thread monai/transforms/utility/dictionary.py Outdated
Comment thread tests/test_apply_transform_to_pointsd.py
Comment thread monai/transforms/utility/dictionary.py Outdated
KumoLiu and others added 5 commits September 3, 2024 15:55
@KumoLiu KumoLiu requested a review from ericspod September 3, 2024 08:53
Comment thread tests/test_apply_transform_to_pointsd.py

@ericspod ericspod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a minor point on tests but otherwise it looks good.

@KumoLiu

KumoLiu commented Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

/build

Comment thread monai/transforms/utility/dictionary.py
Signed-off-by: YunLiu <[email protected]>
@KumoLiu

KumoLiu commented Sep 4, 2024

Copy link
Copy Markdown
Contributor Author

/build

@KumoLiu

KumoLiu commented Sep 4, 2024

Copy link
Copy Markdown
Contributor Author

/build

@KumoLiu KumoLiu merged commit 4e70bf6 into Project-MONAI:dev Sep 4, 2024
@KumoLiu KumoLiu deleted the enhance-applypoints branch September 4, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants