Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix IgniteInfo can not import issue#8121

Merged
KumoLiu merged 4 commits into
Project-MONAI:devfrom
KumoLiu:ignite-fix
Sep 30, 2024
Merged

Fix IgniteInfo can not import issue#8121
KumoLiu merged 4 commits into
Project-MONAI:devfrom
KumoLiu:ignite-fix

Conversation

@KumoLiu

@KumoLiu KumoLiu commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Fixes #8120 .

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <[email protected]>
@KumoLiu

KumoLiu commented Sep 30, 2024

Copy link
Copy Markdown
Contributor Author

/build

1 similar comment
@KumoLiu

KumoLiu commented Sep 30, 2024

Copy link
Copy Markdown
Contributor Author

/build

@mingxin-zheng

Copy link
Copy Markdown
Collaborator

Hi @KumoLiu , do you think we'll need to change this line too?

OPT_IMPORT_VERSION = "0.4.4"

The version of Ignite in requirements-dev.txt is 0.4.11

Comment thread monai/config/deviceconfig.py Outdated
Comment thread monai/config/deviceconfig.py Outdated
Signed-off-by: YunLiu <[email protected]>
@KumoLiu

KumoLiu commented Sep 30, 2024

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: YunLiu <[email protected]>
@KumoLiu

KumoLiu commented Sep 30, 2024

Copy link
Copy Markdown
Contributor Author

/build

@mingxin-zheng

mingxin-zheng commented Sep 30, 2024

Copy link
Copy Markdown
Collaborator

By the way, do you think a deprecated class should also be included in the __all__ definitions?

I don't have a strong opinion on this. Either way makes sense.

@KumoLiu

KumoLiu commented Sep 30, 2024

Copy link
Copy Markdown
Contributor Author

By the way, do you think a deprecated class should also be included in the __all__ definitions?

Yes, added.

@KumoLiu

KumoLiu commented Sep 30, 2024

Copy link
Copy Markdown
Contributor Author

/build

@KumoLiu KumoLiu merged commit 76ef9f4 into Project-MONAI:dev Sep 30, 2024
@KumoLiu KumoLiu deleted the ignite-fix branch September 30, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cannot import name 'IgniteInfo' from 'monai.config'

2 participants