Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: #108 fine grained observability#110

Merged
thescientist13 merged 12 commits intomasterfrom
feature/issue-108-fine-grained-observability
Jan 15, 2026
Merged

feat: #108 fine grained observability#110
thescientist13 merged 12 commits intomasterfrom
feature/issue-108-fine-grained-observability

Conversation

@thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Jan 4, 2023

Related Issue

resolves #108

demo PR available at thescientist13/greenwood-counter-jsx#3

Summary of Changes

  1. Fine grained observability for basic textContent replacements

TODO

  1. Fine grained observability for Shadow DOM
  2. Attributes
  3. Testing
  4. Documentation
    • JSX expressions must be wrapped in a tag
  5. rebase + validate all sandbox examples
  6. sync with upstream example (get it working for dev and build)
  7. expressions result in unexpected placeholders, e.g. counter-dsd.tsx (separate issue is that the width prop is missing!)
    <img width={10} />
    <img data-wcc-undefined="width" data-wcc-ins="attr">
  8. more test cases
  9. handle this patch for proper attributes update tracking (rebase after fix: #219 preserve JSX literal attribute expressions #220 and add test case) - https://github.com/thescientist13/wcc-jsx-to-signals/commit/c1e8b161e53626b9433fee3b03691a9bff30337a#diff-e9c5473d52ced93bb8c448f6c0acd03932ade34ce1d2ed0a17d42ff8badcc051R102
  10. handle this patch for empty strings breaking change detection - https://github.com/thescientist13/wcc-jsx-to-signals/commit/7f6ea885f267c3d4d7045fa07f27cbe36f10478d#diff-e9c5473d52ced93bb8c448f6c0acd03932ade34ce1d2ed0a17d42ff8badcc051R442
  11. greenwood upstream testing
  12. clean up console logs / comments / etc
  13. track all TODOs / nice to haves - will save these for the signals hacking

NICE TO HAVE

  1. Can it handle things like loops, like a list? (e.g. Todo App)
    • actually, when / if everything is just "signals" does the initial render matter?
  2. (nice to have) Co-mingled interpolations - make it so JSX expressions don't have to be wrapped in DOM elements, e.g.
    // does not work
    <h1>Hello, {greeting}!</h1>
    
    <span class={conditionalClass}>{count}{conditionalText}</span>
    
    // works
    <h1>Hello, <span>{greeting}</span>!</h1>
    
    <span class={conditionalClass}><span>{count}</span>{conditionalText}</span>
  3. be able to remove this extra data attribute (name and instruction), e.g.
    // string = `${string.slice(0, string.lastIndexOf('>'))} data-wcc-${name} data-wcc-ins="text">`

@thescientist13 thescientist13 added documentation Improvements or additions to the website and / or documentation feature New feature or request expirement JSX labels Jan 4, 2023
@thescientist13 thescientist13 self-assigned this Jan 4, 2023
@thescientist13 thescientist13 force-pushed the feature/issue-108-fine-grained-observability branch from 31732b1 to ab02ab7 Compare January 2, 2024 16:44
@thescientist13 thescientist13 changed the title implementing fine grained observability feature/issue 108 implementing fine grained observability Jan 6, 2024
@thescientist13 thescientist13 changed the title feature/issue 108 implementing fine grained observability feature/issue 108 fine grained observability Jan 9, 2024
@thescientist13 thescientist13 force-pushed the feature/issue-108-fine-grained-observability branch from ab02ab7 to 83ea8f1 Compare January 9, 2024 02:17
@thescientist13 thescientist13 added the invalid This doesn't seem right label Oct 25, 2025
@thescientist13 thescientist13 changed the title feature/issue 108 fine grained observability feat: #108 fine grained observability Dec 29, 2025
@thescientist13 thescientist13 removed the invalid This doesn't seem right label Dec 29, 2025
@thescientist13 thescientist13 force-pushed the feature/issue-108-fine-grained-observability branch from 7e6054a to 1606fc8 Compare December 29, 2025 22:03
@thescientist13 thescientist13 marked this pull request as ready for review December 31, 2025 01:55
@thescientist13 thescientist13 force-pushed the feature/issue-108-fine-grained-observability branch from 96f9d44 to a61dbdf Compare January 8, 2026 03:20
@thescientist13 thescientist13 mentioned this pull request Jan 14, 2026
30 tasks
@thescientist13 thescientist13 merged commit 9627895 into master Jan 15, 2026
12 checks passed
@thescientist13 thescientist13 deleted the feature/issue-108-fine-grained-observability branch January 15, 2026 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to the website and / or documentation expirement feature New feature or request InferredObservability JSX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fine Grained Inferred Observability for JSX

1 participant