Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add comments to metrics code and add error handling #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Mar 20, 2024

Adds a try-except block to help debug if github secret isn't being accessed or is malformed

Adds comments and docstrings throughout.

Still need to update contributing guide.

@jukent jukent requested a review from erogluorhan March 20, 2024 02:03
@jukent jukent requested a review from a team as a code owner March 20, 2024 02:03
@jukent jukent requested review from dopplershift and removed request for a team March 20, 2024 02:03
@jukent jukent merged commit 8bc81bb into ProjectPythia:main Mar 20, 2024
@jukent
Copy link
Contributor Author

jukent commented Mar 20, 2024

Thanks for the review @erogluorhan because of this I can tell that the length of our key is 1732. This is good news because I was afraid it would return a length 0 or be unable to find the secret, which is a much harder problem to solve.

One discrepancy in the key that I encountered is sometimes all of the '\n' characters added to a GH secret are rendered as '\n'. I don't completely know why this is, but I saw it come up a lot when I was wrestling with this malformed key error. Perhaps it is because in secrets '' is an escape character, or something is lost during the encryption.

Incidentally, if I take the known key and replace those characters locally, it has length 1732. I'm going to add a quick string manipulation in another PR that should ensure our key has one slash instead of two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants