optimized QubitOperator subtraction#132
Merged
damiansteiger merged 1 commit intoJul 13, 2017
Merged
Conversation
Contributor
Author
|
I might add that I basically just copied the structure of how I previously implemented iadd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved the implementation of the isub and sub routines in QubitOperator so that several unnecessary copies are avoided. Surprisingly, this optimization led to significantly better performance in some code that Ian and I are working on. One should not simply implement isub as += - QubitOp because that causes an unnecessary copy. In cases where these operators are large, this can create problems. I also added a few spaces to some of the docs as there was inconsistent spacing.