Fix first SSC login appearance reset for new players#3226
Open
Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Open
Fix first SSC login appearance reset for new players#3226Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Conversation
Greptile SummaryFixed appearance reset bug for first-time SSC players by detecting seeded database rows with missing appearance fields and syncing them from the client's character data at login.
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 9a6c6a3 |
Contributor
|
Was this an issue prior to #3199 ? Just curious. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players reported that with SSC enabled, first-time players can get default appearance values after they log in.
This patch keeps SSC behavior the same, but if the seeded tsCharacter row has missing appearance fields, it fills them from the current player data at login and reloads PlayerData.
It is applied in all login paths (UUID login, password login, and /login).