[perf] Cache chat command prefix lookup in OnChat#3230
Open
Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Open
[perf] Cache chat command prefix lookup in OnChat#3230Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Conversation
Replace per-message iteration over ChatManager localized commands with direct lookup through EnglishLanguage.GetCommandPrefixByName using the command id name. This aligns command reconstruction with the cached vanilla command map and removes unnecessary hot-path enumeration in OnChat.
Greptile SummaryOptimized chat command prefix lookup in
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 7d38357 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code runs on every chat message that uses command ids.
This patch removes per-message iteration over localized commands and uses direct lookup through
EnglishLanguage.GetCommandPrefixByName.Behavior stays the same; it only reduces work in chat reconstruction.