[perf/fix] Correct projectile tracking updates and reduce list scans#3231
Open
Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Open
[perf/fix] Correct projectile tracking updates and reduce list scans#3231Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Xekep wants to merge 1 commit intoPryaxis:general-develfrom
Conversation
Correct projectile kill marking for ProjectileStruct entries (value-type updates were previously lost), serialize recent-projectile updates in NetHooks_SendData, and reduce repeated list scans in projectile tracking paths. Also standardize projectile recency timestamps and cleanup thresholds to DateTime.UtcNow to avoid clock-shift inconsistencies.
Greptile SummaryThis PR addresses performance and correctness issues in projectile tracking hot paths. It fixes a critical bug where the Key Changes:
The changes preserve existing behavior while making projectile tracking more correct and efficient during packet-heavy combat scenarios. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 1f6705f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Players reported lag under load in packet-heavy combat.
This patch fixes value-type update loss when marking tracked projectiles as killed, replaces repeated LINQ scans in projectile tracking hot paths with loops, and uses consistent UTC timestamps for recency checks.
Behavior is preserved, but tracking is more correct and cheaper under load.