chain (multi-root): 3 issues — spectra-archive sync + cluster glob + pasted-image cache - #115

…n A-final doc (#100)

#100 Finding 1 (design) — Option A confirmed final:

NEW `### Feature-branch + cluster + direct-commit — rejected case` subsection
in `references/pr-flow.md` § Cluster mode override. Documents the rejected
Option B (branch-context-gated cluster direct-commit) with comparison table
+ rationale. Contract simplicity wins; users who want feature-branch
direct-commit workflow can use single-issue `--no-pr` invocations or
cherry-pick post-merge.

#100 Finding 2 (refactor) — glob hardening:

`skills/idd-implement/SKILL.md` Step 0.5 cluster detection bash. Previous
glob `\#[0-9]*` over-matched:
- `#42abc` → matched (`*` absorbed trailing letters) — counted malformed
- `#34 #34` → counted as 2 (duplicate) — tripped CLUSTER_MODE on 1 distinct

Replaced with strict integer check + associative-array dedup:

  case "$arg" in
    \#*)
      arg_num="${arg#\#}"
      if [[ "$arg_num" =~ ^[0-9]+$ ]] && [ -z "${SEEN_ISSUES[$arg_num]:-}" ]; then
        SEEN_ISSUES[$arg_num]=1
        ISSUE_COUNT=$((ISSUE_COUNT + 1))
      fi
      ;;
  esac

Matches batch-and-cluster.md documented `^#\d+$` form. 0 behavior change
for well-formed distinct invocations. Malformed tokens (`#42abc`) silently
skipped — counter doesn't trip on garbage. Duplicates collapse to 1.

Refs #100

#112 surfaced that Claude Code's ~/.claude/image-cache/<session-id>/ is
per-session + cleared by context compaction / session lifecycle / session-id
rollover. Step 1 → Step 4 separation (read annotation in Step 1, upload in
Step 4) spans AskUserQuestion + Step 2.5/2.6 + Step 3 `gh issue create` +
Step 4 upload — easily long enough for cache eviction. Step 4's
`gh release upload <image-cache-path>` fails when `ls` returns nothing.
2026-05-20 downstream incident (kiki830621/ai_martech_global_scripts#788)
hit exactly this failure mode.

Two changes to skills/idd-issue/SKILL.md Step 1 Source Type Adapter:

1. NEW "Pasted image" row in Source Type Adapter table — explicit
   immediate-persistence rule (cp in the same tool turn that reads the
   annotation, not deferred).

2. Updated "Mixed (text + 圖片貼上)" row — explicitly references the
   pasted-image immediate-persistence rule for every pasted image; the
   pre-existing "使用者另外提供 path 清單" is preserved as the
   non-pasted-image case (paths that already point at stable files outside
   the per-session image cache).

3. NEW `### Pasted-image immediate-persistence (v2.70.0+, #112)`
   subsection between Source Type Adapter and MCP pre-flight. Documents:
   - The cache-eviction failure mode + why immediate persist closes it
   - Bash snippet showing the cp loop + staged-path tracking
   - Step 4 reference contract (iterate PASTED_IMAGES_STAGED, not original cache paths)
   - Staging path naming convention (/tmp/idd-issue-attachments/issue_pending_<ts>_<rand>.png)
     + rationale (POSIX-safe, anonymous, system-cleanup-friendly, no repo pollution)
   - Compaction-resumed session edge case (fallback to warn + continue when source
     already evicted before Step 1)

0 backward compat impact for non-pasted-image sources (docx via export_image,
file paths in stable locations) — change is purely additive for the
[Image: source: ...] annotation path.

Refs #112

Refs #93 #100 #112

… qualifier (#93 #100 #112)

3 non-blocking findings from Devil's Advocate dispatched in-PR per
feedback_verify_fix_same_pr:

DA-1 (MEDIUM) — CHANGELOG #93 entry said "filed for separate follow-up
as needed" but no sister-skill issues were actually filed. Misleading
audit trail per IC_R011 canonical 'file / file selected / skip'
semantics. Softened to "Sister issues NOT auto-filed in this PR per
feedback_lead_minimal — drift documented as observation, separate
issues will be filed if specific divergence causes user-visible
friction". Cites DA finding DA-1 for traceability.

DA-2 (LOW) — #100 cluster glob hardening had a quiet behavior change
for malformed tokens (#42abc previously counted as cluster member;
post-v2.70.0 silently skipped). CHANGELOG #100 entry extended with
explicit backward-compat note: failure modes shifted from 'fail
mid-loop on bad number' to 'treat as if token not present'.

DA-4 (LOW) — softened the "ONLY authoritative source" claim in the
PASTED_IMAGE_PATHS source contract from absolute to qualified-by-version:
'currently the only authoritative source per the v2.70.0+ Claude Code
prompt format'. Adds explicit note that future Claude Code versions
(drag-drop / other annotation forms) may require contract extension.

Codex nit — table row + subsection wording updated from
'issue_pending_<ts>_<rand>.png' to 'issue_pending_XXXXXX.png (via mktemp)'
to match the post-fix mktemp-based impl (commit 8b15784).

DA-3 (LOW) staged_base.png stale leftover — not fixed in this commit;
mktemp guarantees fresh uniqueness so stale-overwrite is only possible
under hostile pre-creation by attacker (out of scope for IDD threat
model — no user-controlled write path to /tmp/idd-issue-attachments/).

Refs #93 #100 #112