Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update mariadb tests to 10.8, remove end of life mariadb 10.2 #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

Nothing4You
Copy link
Contributor

No description provided.

@tgross35
Copy link

tgross35 commented Jun 13, 2022

Out of curiosity - why are specific (and seemingly random) combinations listed? E.g. mdb10.7 + 3.11-dev, but 10.8 runs with 3.9

Seems like it would make sense to just matrix all possible combinations outside of the include key, e.g.

matrix:
  - db: ["mariadb:10.3", "mariadb:10.4", "mariadb:10.5", "mariadb:10.6", "mariadb:10.7", "mariadb:10.8"]
    py: ["3.7", "3.8", "3.9", "3.10", "3.11-dev"]

This isn't specific to this PR, just a general question

@methane methane merged commit 72ee1f3 into PyMySQL:main Jun 14, 2022
@methane
Copy link
Member

methane commented Jun 14, 2022

Out of curiosity - why are specific (and seemingly random) combinations listed? E.g. mdb10.7 + 3.11-dev, but 10.8 runs with 3.9

Seems like it would make sense to just matrix all possible combinations outside of the include key, e.g.

Because it is very unlikely there is a bug happen only in specific combination of Python version and DB version.

I don't waste energy and computing resources because:

  • MS helps OSS a lot, but it is limited resource. We are free riding on it.
  • Using some energy cause:
    • Emits some CO2
    • Keep energy price high - keep fuel price high - keep Russian invation

Every 1Wh is 1ml of blood.

@Nothing4You Nothing4You deleted the mariadb-10.8 branch June 14, 2022 08:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants