Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix/unsafe ids #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/unsafe ids #1207

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21a7bfc
escape composed identifiers
soshtolsus Apr 10, 2025
cb45050
cleanup and modernization
soshtolsus Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup and modernization
  • Loading branch information
@soshtolsus
soshtolsus committed Apr 10, 2025
commit cb45050004398349c71d84937d8f8e7b56b5440f
15 changes: 4 additions & 11 deletions pymysql/cursors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,20 +252,13 @@ def callproc(self, procname, args=()):
disconnected.
"""
conn = self._get_db()
server_params = {f'`@_{procname}_{index:d}`': arg for index,arg in enumerate(args)}

if args:
fmt = f"`@_{procname}_%d`=%s"
self._query(
"SET %s"
% ",".join(
fmt % (index, conn.escape(arg)) for index, arg in enumerate(args)
)
)
self._query("SET {}".format(",".join("{k}={v}" for k,v in server_params.items())))
self.nextset()

q = "CALL `{}`({})".format(
procname,
",".join(["`@_%s_%d`" % (procname, i) for i in range(len(args))]),
)
q = f"CALL `{procname}`({{}})".format(",".join(server_params.keys()))
self._query(q)
self._executed = q
return args
Expand Down