Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: ♻️ Make Attachment.save clearer by expliciting that chunksize is non-null #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: ♻️ Make Attachment.save clearer by expliciting that chunksize is non-null #2991

wants to merge 3 commits into from

Conversation

@Paillat-dev
Copy link
Member

@Paillat-dev Paillat-dev commented Nov 6, 2025

Summary

image

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev requested a review from a team as a code owner November 6, 2025 16:19
@pycord-app
Copy link

pycord-app bot commented Nov 6, 2025

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/2991/head:pr-2991
git checkout pr-2991

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2991/head

@Paillat-dev Paillat-dev requested a review from DA-344 November 6, 2025 16:19
@Paillat-dev Paillat-dev marked this pull request as draft November 6, 2025 17:52
@Paillat-dev Paillat-dev force-pushed the fix/oopsie-chunked-attachment branch from 8eedd58 to fb74ffc Compare November 6, 2025 17:58
@Paillat-dev Paillat-dev changed the title fix: 🐛 Add explicit checks for chunksize value fix: ♻️ Make Attachment.save clearer by expliciting that chunksize is non-null Nov 6, 2025
@Paillat-dev Paillat-dev marked this pull request as ready for review November 6, 2025 17:59
@Paillat-dev Paillat-dev force-pushed the fix/oopsie-chunked-attachment branch from fb74ffc to 590c556 Compare November 6, 2025 17:59
@Paillat-dev Paillat-dev force-pushed the fix/oopsie-chunked-attachment branch from 590c556 to d2da9ef Compare November 6, 2025 18:49
plun1331
plun1331 requested changes Nov 6, 2025
View reviewed changes
Paillat-dev and others added 2 commits November 6, 2025 20:08
@Paillat-dev @plun1331
Update discord/message.py
44a5e7f 
Co-authored-by: plun1331 <[email protected]>
Signed-off-by: Paillat <[email protected]>
@Paillat-dev @plun1331
Update discord/message.py
e2532d9 
Co-authored-by: plun1331 <[email protected]>
Signed-off-by: Paillat <[email protected]>
@plun1331
Copy link
Member

plun1331 commented Nov 6, 2025 •
edited
Loading

oh, changelog
also needs testing

@plun1331 plun1331 added the bug Something isn't working label Nov 6, 2025
@Paillat-dev
Copy link
Member Author

Paillat-dev commented Nov 6, 2025 •
edited
Loading

I don't think changelog is required, this should have been in the og pr, and for testing, doesn't change the actual logic, because in case chunksize is 0 or negative, an error is raised so it can't ever go down and propagate to the other checks, it's just for readability (see discord discussion for more context)

@plun1331
Copy link
Member

plun1331 commented Nov 6, 2025

fair enough, still needs to be tested

@Paillat-dev Paillat-dev added the hold: testing This pull request requires further testing label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@plun1331 plun1331 plun1331 approved these changes

@DA-344 DA-344 Awaiting requested review from DA-344

Assignees

No one assigned

Labels

bug Something isn't working hold: testing This pull request requires further testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Paillat-dev @plun1331 @Lulalaby