Support Python 3.14#84
Merged
Merged
Conversation
Collaborator
Author
|
FWIW, I've been tweaking and running the SciPy tests today and have not seen a single case where a test involving warnings running in parallel fails. I think |
Collaborator
Author
|
I ended up punting on the numpy test utility detection. In practice only numpy and scipy used the unsafe functions and we've already migrated both libraries away. This is ready for review now. |
lysnikolaou
reviewed
Jul 22, 2025
Contributor
lysnikolaou
left a comment
There was a problem hiding this comment.
Looks good. Left some comments inline. Can we also add CI for 3.14-dev?
Collaborator
Author
|
Ah I guess we need to switch back to |
This was referenced Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as a draft because of the hacky detection for
suppress_warnings. I'm also not completely sure that the SciPy unit tests safely finish running with this PR applied.EDIT: maybe adding numpy as a test dependency is overkill?