-
-
Notifications
You must be signed in to change notification settings - Fork 4
Update font in matplotlib #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks @HumphreyYang. It appears this isn't the driving issue though latex was not able to process the following string:
b'$E[y_t]$ \\u968f\\u65f6\\u95f4\\u53d8\\u5316' still getting this lecture failure. I will have to take a closer look. |
Many thanks @mmcky, This is wierd, but I think it might still be beneficial to have these added to the matplotlib paramters : ) |
thanks @HumphreyYang that cell is not working if there are ANY chinese characters used. All lines need to be removed for the latex to work. Is there an unusual character in each line? Do we need to enable an extended chinese character set? ![]() One solution is to declare any missing unicode in a preamble. but I think that is probably not a great solution in this case. |
Many thanks @mmcky, This is strange. I thought it is related to matplotlib titles. Is xlabel working? |
No if any combination is enabled the latex conversion fails. |
Thanks @mmcky, That's sad : ( I wonder why we did not hit this issue in the intro series. |
It's only an issue with this one code-cell as far as I can tell. The other lectures are running fine, that is why I was wondering if there was an unusual chinese character not defined in the standard utf8? |
Hi Matt, Let me try to rewrite this sentence and see if we get the same errror! |
It's actually an issue for that lecture more broadly. I was looking at disabling the Chinese characters in matplotlib figure generation and for some reason that lecture is having issues. |
Hi @mmcky, I think I know what happened! I wrote this lecture with Tom and at that time I wanted to add matrices to the matplotlib plots. So I have those lines at the beginning:
Appearently this has forced I guess all I need to do is to add the usage the package that support chinese characters here. |
Hi @mmcky, I fixed Kalman_2 in the latest push! Everything now runs perfectly on my end! |
Nice work @HumphreyYang. Thanks. There is starting to be a lot of setup to include the characters in latex + matplotlib |
thanks @HumphreyYang -- merging this to get the cache building. I have verified local execution as well. |
Hi @mmcky,
On a second thought, I think we should add them to every lecture with matplotlib, and then ask RAs to review if they are needed.
This way we can avoid build errors first.
This PR should fix #7.
Best,
Humphrey