Add property wrapper default initializer for TestState #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younata
approved these changes
Aug 28, 2023
younata
reviewed
Aug 28, 2023
Member
younata
left a comment
There was a problem hiding this comment.
Omg, I'm so sorry for forgetting about this until now. This is great, thank you so much!
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Sep 18, 2023
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [Quick/Quick](https://togithub.com/Quick/Quick) | minor | `from: "7.2.0"` -> `from: "7.3.0"` | --- ### Release Notes <details> <summary>Quick/Quick (Quick/Quick)</summary> ### [`v7.3.0`](https://togithub.com/Quick/Quick/releases/tag/v7.3.0) [Compare Source](https://togithub.com/Quick/Quick/compare/v7.2.0...v7.3.0) #### Highlights - Adds a property wrapper default initializer for TestState. Meaning the following declaration is now accepted! ```swift @​TestState var foo: Int! = 30 ``` Thanks [@​tahirmt](https://togithub.com/tahirmt)! - TestState now nils out the value after all afterEach blocks run, instead of in the middle of the afterEach chain. Thanks [@​CraigSiemens](https://togithub.com/CraigSiemens) #### What's Changed - Bump activesupport from 7.0.4.3 to 7.0.7.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Quick/Quick/pull/1238](https://togithub.com/Quick/Quick/pull/1238) - Add property wrapper default initializer for TestState by [@​tahirmt](https://togithub.com/tahirmt) in [https://github.com/Quick/Quick/pull/1235](https://togithub.com/Quick/Quick/pull/1235) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Quick/Quick/pull/1241](https://togithub.com/Quick/Quick/pull/1241) - Updated TestState to remove the value after the test. by [@​CraigSiemens](https://togithub.com/CraigSiemens) in [https://github.com/Quick/Quick/pull/1240](https://togithub.com/Quick/Quick/pull/1240) - Update release script to generate a carthage binary and include it in the release. by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Quick/pull/1234](https://togithub.com/Quick/Quick/pull/1234) #### New Contributors - [@​tahirmt](https://togithub.com/tahirmt) made their first contribution in [https://github.com/Quick/Quick/pull/1235](https://togithub.com/Quick/Quick/pull/1235) **Full Changelog**: Quick/Quick@v7.2.0...v7.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@TestStateproperty wrapper was reintroduced in #1233. It currently requires initial value in the wrapper to be passed in but we can't use the assignment operator. By adding the expected initializer forpropertyWrapperwe can support just initializing naturally. Even support type inference.Before
After
This change is non-breaking and does not change the existing behavior.
Checklist - While not every PR needs it, new features should consider this list: