Add visionOS support #1249
Merged
Add visionOS support #1249
+101
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icit Package.swift file
94b60c6 to
a4e42fd
Compare
5331a92 to
487c837
Compare
Contributor
Author
stonko1994
commented
Jan 23, 2024
| desc "Run lint for podspec" | ||
| task :lint do | ||
| run "bundle exec pod lib lint" | ||
| run "bundle exec pod lib lint --platforms=ios,tvos,macos" |
Contributor
Author
There was a problem hiding this comment.
We need to skip visionos for now as the CI does not yet have visionOS simulators installed. We did the same for Nimble and need to revisit this once available.
Contributor
Author
|
@younata I 'fixed' the cocoapod lint step by skipping visionOS for now. However, I don't understand why the danger step is failing 👀 Do you have any insights there? |
Member
It's because this PR is not from the Quick org. It's some permissions issue that I haven't thought to figure out. Don't worry about it. This s good to merge. |
Member
|
And included in Quick 7.4.0! Thanks! https://github.com/Quick/Quick/releases/tag/v7.4.0 |
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jan 24, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [Quick/Quick](https://togithub.com/Quick/Quick) | minor | `from: "7.3.1"` -> `from: "7.4.0"` | --- ### Release Notes <details> <summary>Quick/Quick (Quick/Quick)</summary> ### [`v7.4.0`](https://togithub.com/Quick/Quick/releases/tag/v7.4.0): - visionOS support [Compare Source](https://togithub.com/Quick/Quick/compare/v7.3.1...v7.4.0) ### Highlights - Quick now supports visionOS! Thanks [@​stonko1994](https://togithub.com/stonko1994)! Note: This version of Quick is not yet in Cocoapods, see [https://github.com/CocoaPods/CocoaPods/issues/12118](https://togithub.com/CocoaPods/CocoaPods/issues/12118) ### Autogenerated Release Notes #### What's Changed - Release script should auto-update local ruby dependencies by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Quick/pull/1263](https://togithub.com/Quick/Quick/pull/1263) - Add visionOS support by [@​stonko1994](https://togithub.com/stonko1994) in [https://github.com/Quick/Quick/pull/1249](https://togithub.com/Quick/Quick/pull/1249) #### New Contributors - [@​stonko1994](https://togithub.com/stonko1994) made their first contribution in [https://github.com/Quick/Quick/pull/1249](https://togithub.com/Quick/Quick/pull/1249) **Full Changelog**: Quick/Quick@v7.3.1...v7.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246
Description
This PR adds visionOS support to Quick 🥳
Before this PR can be merged, the counterpart PR in Nimble needs to be merged:
Checklist - While not every PR needs it, new features should consider this list: