Mark tested which are pended-out or not focused as skipped. #1276
+208
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, if a test is pended out (using pending, xcontext, xdescribe, xit, xitBehavesLike), then the test will be marked as if you had immediately thrown an XCTSkip error. Similarly, if there is a test that is focused (using fcontext, fdescribe, fit, fitBehavesLike), then all non-focused tests will be marked as if you had immediately thrown an XCTSkip error.
Generated by 🚫 Danger |
Member
Author
|
Hm, trying this in a larger codebase, specs in classes that are run before the class with the focused spec will also be ran. Per Additionally, if there are focused specs in |
…kSpec and vice-versa
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Mar 25, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [Quick/Quick](https://togithub.com/Quick/Quick) | minor | `from: "7.4.1"` -> `from: "7.5.0"` | --- ### Release Notes <details> <summary>Quick/Quick (Quick/Quick)</summary> ### [`v7.5.0`](https://togithub.com/Quick/Quick/releases/tag/v7.5.0): - Pending tests are now marked as Skipped in Xcode [Compare Source](https://togithub.com/Quick/Quick/compare/v7.4.1...v7.5.0) #### Highlights - Any tests which are pended-out (using `pending`, `xdescribe`, `xcontext`, `xitBehavesLike`, or `xit`), OR tests which are skipped because they are not focused (that is, the **other** tests when you use `fdescribe`, `fcontext`, `fitBehavesLike` or `fit`) are now marked as skipped in Xcode. #### Automated Changelog - Bump softprops/action-gh-release from 1 to 2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/Quick/Quick/pull/1274](https://togithub.com/Quick/Quick/pull/1274) - Mark tested which are pended-out or not focused as skipped. by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Quick/pull/1276](https://togithub.com/Quick/Quick/pull/1276) **Full Changelog**: Quick/Quick@v7.4.1...v7.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
|
Hey @younata would be open to a PR that adds additional configuration flag to opt out of this? In our current biggest project the performance penalty is extremely severe (3-4 times longer than it used to be to run a focused spec) and this is hindering engineers performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our pending behavior. Now, we will make sure that all tests that Quick skips using
pending,xdescribe,xit,xitBehavesLikeare marked as skipped in the Xcode test navigator.Similarly, if you have focused a test using
fcontext,fdescribe,fit,fitBehavesLike, then Quick will mark all the other tests as skipped in the Xcode test navigator.Sadly, this does come with a performance regression. Perhaps in the future, Xcode will expose an API for us to mark tests as skipped in bulk. I filed a request for such an API as FB13696046.
Fixes #332
Fixes #770
Fixes #1093