Add nullability annotations to the objective-c header files #1291
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
3d790bc to
66736b4
Compare
1 task
|
@younata : Hi, i tested my changes with this branch, it worked. Though i have to now explicitly "import Foundation " framework in my test classes where i am using Date() objects also have to "import XCTest" , wherever i have used XCTests to validate. It was not the case when i was using Quick and Nimble Cocoapods. Please plan to merge this branch. Thanks a lot ! |
|
Hello @younata : Good day ! Can we merge this PR ? Or any ETA when this will be merged. Regards |
Member
Author
|
Hey @gaurav-Lilly, thanks for the ping. I merged and released this just now as version 7.6.2. |
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Aug 24, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [Quick/Quick](https://togithub.com/Quick/Quick) | patch | `from: "7.6.1"` -> `from: "7.6.2"` | --- ### Release Notes <details> <summary>Quick/Quick (Quick/Quick)</summary> ### [`v7.6.2`](https://togithub.com/Quick/Quick/releases/tag/v7.6.2) [Compare Source](https://togithub.com/Quick/Quick/compare/v7.6.1...v7.6.2) #### What's Changed - Add nullability annotations to the objective-c header files by [@​younata](https://togithub.com/younata) in [https://github.com/Quick/Quick/pull/1291](https://togithub.com/Quick/Quick/pull/1291) **Full Changelog**: Quick/Quick@v7.6.1...v7.6.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM4LjQwLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com> Co-authored-by: Chuck Grindel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #1290?
Adds long-awaited nullability annotations to the objective-c header files.