Remove dependence on UIKit; fix use of deprecated UUID attribute #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFduino
added a commit
that referenced
this pull request
Apr 14, 2015
Remove dependence on UIKit; fix use of deprecated UUID attribute
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First issue - when adding the RFduino classes to a Swift project, UIKit is not available to RFduinoManager. It shouldn't really be anyway - instead I added an optional method to RFduinoManagerDelegate to request that the user of the manager display a message if it wishes.
Second, after iOS 7.1 CBPeripheral's uuid attribute is deprecated. Used peripheral.identifier.UUIDString instead of peripheral.UUID.
Third, fixed a couple of type warnings.