Feature journal control merge files#275
Merged
Merged
Conversation
konglobemeralt
approved these changes
Jul 16, 2020
konglobemeralt
left a comment
Member
There was a problem hiding this comment.
Had to run "manually" but other than that it works fine and I can't find anything to complain about in the code.
…aestro into feature_journalControlMergeFiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #274 . This PR adds the actual merging of the files. Turns out that ObjectControl is the only module which used to send data to Logger while in the running state, so the output log from JournalControl only contains data from there by default... we will have to implement some more actual (non-LogMessage) logging in scenario control.
If you wish to test the behaviour manually, just create a file in
~/.maestro/journalnamed WhatEverNameControl-2020-07-13.jnl (current date) and append some stuff to it while a test is running. The format is<epoch timestamp in s>: <data>\n,and the output file is named based on the ScenarioName parameter in
test.confe.g. UnnamedScenario.jnlOr you could call
JournalRecordStringfrom some other module than ObjectControl, in the running state.Remember that
JournalRecordStringshould not be used for things like "SystemControl connected to IP x.x.x.x" so that we can keep the output easy to parse by e.g. excel.