@amd-shahab If this shouldn't be tested yet and isn't mergeable until the dependent PR, feel free to label it "ci:skip".

• error string not part of API

• __hipOnError -> @samp{__hipOnError}

• "int main" -> "int\nmain"

• gdb_test -> gdb_test_on_output

• target_read_stack -> target_read_memory

• drop the "ignored" param name

• Else -> Otherwise

• NULL -> nullptr

• removed dangling "backtrace" command from the documentation

• !arg -> arg != nullptr

• binay -> binary

• relvant -> relevant

• bool print_one (const bp_location **) -> bool print_one (const bp_location **last_loc)

• rename variable "x" to "dontcare"

• comment on true/false return of amd64_fetch_hiperr_parameters()

• emit a warning when the "version" is not expected.

• make the invocation of the test fully argument dependent
• add comments for every method in break-catch-hiperr.c

• check for the existence of __hipOnError symbol. If not found, skip the test.

• check for the right frame (__hipOnError)

If I set the feature with "catch hiperr" and then do an infcall with "print hipSetDevice(98765)", what's GDB's behavior? Can you please check?

If I set the feature with "catch hiperr" and then do an infcall with "print hipSetDevice(98765)", what's GDB's behavior? Can you please check?

I have not tested, but am highly confident that this will trigger the catch point.

If I set the feature with "catch hiperr" and then do an infcall with "print hipSetDevice(98765)", what's GDB's behavior? Can you please check?

I have not tested, but am highly confident that this will trigger the catch point.

I also think the catchpoint will be triggered but just in case I wanted make sure GDB can handle the infcall interruption correctly. It would be great to test with and without set unwind-on-signal on. (I cannot test because I don't have the hipOnError symbol.

If I set the feature with "catch hiperr" and then do an infcall with "print hipSetDevice(98765)", what's GDB's behavior? Can you please check?

As Lancelot predicted:

(gdb) catch hiperr
Catchpoint 2 (HIP error)
(gdb) p hipSetDevice(98765)
[New Thread 0x7ffff4fff6c0 (LWP 8965) (id 2)]
[New Thread 0x7ffff47fe6c0 (LWP 8966) (id 3)]
[New Thread 0x7ffff3cff6c0 (LWP 8967) (id 4)]
[Thread 0x7ffff3cff6c0 (LWP 8967) (id 4) exited]

Thread 1 "hip-catch-error" hit Catchpoint 2 (HIP error)
HIP API call failed with error hipErrorInvalidDevice (101): invalid device ordinal

The $_hiperr holds the error number.
A "backtrace" will show the call stack.
The program being debugged stopped while in a function called from GDB.
Evaluation of the expression containing the function
(hipSetDevice(int)) will be abandoned.
When the function is done executing, GDB will silently stop.


(gdb) bt
#0  __hipOnError (err_info=0x7fffffffd7a0) at /src/clr/hipamd/src/hip_error.cpp:11
#1  0x00007ffff62863e9 in hip::hipSetDevice (device=98765) at /src/clr/hipamd/src/hip_device_runtime.cpp:784
#2  0x00007ffff668440f in hipSetDevice (deviceId=98765) at /src/clr/hipamd/src/hip_table_interface.cpp:2133
#3  <function called from gdb>
#4  main (argc=1, argv=0x7fffffffe108) at /src/rocgdb/gdb/testsuite/gdb.rocm/hip-catch-errors.cpp:26

With set unwind-on-signal on (default is off), we get the same output. "Signal"s have nothing to do with these errors.

• In catchpoint output, refer to "$_hiperr" as a "convenience variable"
• In catchpoint output, change the "backtrace" section to the suggested sentence
• gdb.texinfo updated to reflect the latest output.
• Use "$::hip_" instead of "global hip_"
• Use ATTRIBUTE_UNUSED
• rename the fetch_hiperr parameter names to err_{no,name,str}
• a few typos are fixed

• test: Add an implicit and faulty kernel<<<1, big_size>>> call to HIP API as test case
• test: Make the routine for getting reference values and causing the errors the same

• catch code: Add space before : in struct hiperr_catchpoint: public code_breakpoint
• catch code: get rid of unnecessary line break when adding the "catch hiperr" command
• catch code: Remove mention of backtrace when the catchpoint is hit
• catch code: add a comment that unsucessful fetching of parameters is not a deal breaker
• amd64-tdep.c: "not recognized" -> "not supported"
• amd64-tdep.c: fix bad indentation on line starting with pulongest
• test: anchor the $str in regex HIP API call failed with error $name \\($code\\): $str.*
• test: use lassign instead of repeated lindexs
• test: "same codes are executed" -> "same code is executed"
• test: remove the space in function calls like ... hipGetErrorName ($err)
• doc: use @value{GDBP} instead of (gdb) in example outputs
• doc: turn hip errors in example outputs to HIP errors
• doc: The @samp{$_hiperr} can -> The @samp{$_hiperr} convenience variable can
• commit message:
  . fix typos
  . update the stale outputs
  . use error number, name, and string (same in production and test code)
  . mention backward compatibility of the versions

• test: combine temporary and non-temporary procedures
• test: generate the reference values in the test program itself and read them (instead of inferior calls)

• code: fetch_hiperr_parameters() returns the parameters in an optional struct.
• code: fetch_hiperr_parameters() gets the frame as input
• code: amd64-tde.c reads the structure in one go.
• code: ATTRIBUTE_UNUSED was replaced with commented out variables

• Add intro comment for every function/method/procedures in break-catch-hiperr.c and hip-catch-errors.exp
• Use current_program_space instead of this->pspace when calling the update_breakpoint_locations ()

• Use internationalization for the string_printf () string
• Comment more about the version in amd64-tdep.c