dockerfiles: use NINJA_VERSION instead of CMAKE_VERSION for ./install_ninja.sh#5580
Open
scottt wants to merge 1 commit into
Open
dockerfiles: use NINJA_VERSION instead of CMAKE_VERSION for ./install_ninja.sh#5580scottt wants to merge 1 commit into
scottt wants to merge 1 commit into
Conversation
JeniferC99
requested changes
Jun 2, 2026
JeniferC99
reviewed
Jun 2, 2026
JeniferC99
reviewed
Jun 2, 2026
…_ninja.sh This trivial patch changes the Ninja version string in `build_manylinux_x86_64.Dockerfile` from the currently misnamed `CMAKE_VERSION` to `NINJA_VERSION`. Stella used `CMAKE_VERSION` for the version passed to `./install_ninja.sh` in 02db71e for `build_manylinux_x86_64.Dockerfile`. `build_manylinux_rccl_x86_64.Dockerfile` then inherited that when it was created in cd0270b I create Dockerfiles for more recent Linux distro releases and build TheRock in them to stay one step ahead of breakage from e.g. newer toolchains. Having the CMAKE_VERSION and NINJA_VERSION be distinctly named makes my scripts to sync up the build dependencies easier.
b2fa0e5 to
778a8f7
Compare
Contributor
Author
@JeniferC99 , thanks for catching this! Resolved in the latest version. |
JeniferC99
requested changes
Jun 4, 2026
Contributor
JeniferC99
left a comment
There was a problem hiding this comment.
sorry actually, please don't fork it, instead branch it from main so the CI can run naturally.
JeniferC99
approved these changes
Jun 4, 2026
Contributor
JeniferC99
left a comment
There was a problem hiding this comment.
Looks like I can approve the workflow to run manually. back to +1
Contributor
Author
|
@JeniferC99 , since all CI check passed. could you press the Github "merge" button for me as I can't do it myself as an external contributor? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This trivial patch changes the Ninja version string in
build_manylinux_x86_64.Dockerfilefrom the currently misnamedCMAKE_VERSIONtoNINJA_VERSION.@stellaraccident reused
CMAKE_VERSIONas the name for the variable passed to./install_ninja.shin 02db71e forbuild_manylinux_x86_64.Dockerfile.build_manylinux_rccl_x86_64.Dockerfilethen inherited that when it was created in cd0270bMotivation
I create Dockerfiles for more recent Linux distro releases and build TheRock in them to stay one step ahead of breakage from e.g. newer toolchains. Having the CMAKE_VERSION and NINJA_VERSION be distinctly named makes my scripts to sync up the build dependencies easier.
Submission Checklist