Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TEST - DO NOT MERGE] manifest-diff fork-PR coverage validation (#4908)#5585

Draft
amd-hsivasun wants to merge 29 commits into
ROCm:mainfrom
amd-hsivasun:test/manifest-diff-fork-coverage-2026-06-02
Draft

[TEST - DO NOT MERGE] manifest-diff fork-PR coverage validation (#4908)#5585
amd-hsivasun wants to merge 29 commits into
ROCm:mainfrom
amd-hsivasun:test/manifest-diff-fork-coverage-2026-06-02

Conversation

@amd-hsivasun
Copy link
Copy Markdown
Contributor

Fork-PR test for #4908. Validates the manifest-diff job under the fork-PR
upload path with the new ghcr.io/rocm/therock_build_manylinux_x86_64
container and baseline-credentials mount.

Same commit as PR #4908. Do not merge; will be closed once CI completes.

…cess

Addresses review feedback on ROCm#4908:

- multi_arch_ci.yml: gate manifest_diff caller on
  `github.event_name == 'pull_request' || 'push'` so manual dispatch of
  multi_arch_ci no longer fires a no-op manifest-diff job.
- manifest-diff.yml: switch `continue-on-error: true` to
  `${{ github.event_name != 'workflow_dispatch' }}` so CI invocations stay
  non-blocking but direct dispatch surfaces real script regressions red.
- manifest-diff.yml: tag the report step with `id: gen-report` and gate the
  AWS-credentials and upload steps on `steps.gen-report.conclusion == 'success'`
  so a failed report no longer produces a follow-on "no such file" upload
  failure on top of the real error.
- docs/development/manifest_diff.md: rewrite the "How it runs in CI" section
  into Trigger gating / Failure behavior / Where the report lives subsections;
  fix the S3-layout description (TheRockReport.html keeps its name, index.html
  is a separately generated listing page); document fork-PR credential routing
  through configure_aws_artifacts_credentials.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: TODO

Development

Successfully merging this pull request may close these issues.

1 participant