[TEST - DO NOT MERGE] manifest-diff fork-PR coverage validation (#4908)#5585
Draft
amd-hsivasun wants to merge 29 commits into
Draft
[TEST - DO NOT MERGE] manifest-diff fork-PR coverage validation (#4908)#5585amd-hsivasun wants to merge 29 commits into
amd-hsivasun wants to merge 29 commits into
Conversation
…cess Addresses review feedback on ROCm#4908: - multi_arch_ci.yml: gate manifest_diff caller on `github.event_name == 'pull_request' || 'push'` so manual dispatch of multi_arch_ci no longer fires a no-op manifest-diff job. - manifest-diff.yml: switch `continue-on-error: true` to `${{ github.event_name != 'workflow_dispatch' }}` so CI invocations stay non-blocking but direct dispatch surfaces real script regressions red. - manifest-diff.yml: tag the report step with `id: gen-report` and gate the AWS-credentials and upload steps on `steps.gen-report.conclusion == 'success'` so a failed report no longer produces a follow-on "no such file" upload failure on top of the real error. - docs/development/manifest_diff.md: rewrite the "How it runs in CI" section into Trigger gating / Failure behavior / Where the report lives subsections; fix the S3-layout description (TheRockReport.html keeps its name, index.html is a separately generated listing page); document fork-PR credential routing through configure_aws_artifacts_credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-PR test for #4908. Validates the manifest-diff job under the fork-PR
upload path with the new ghcr.io/rocm/therock_build_manylinux_x86_64
container and baseline-credentials mount.
Same commit as PR #4908. Do not merge; will be closed once CI completes.