[tune] GLM-4.7-FP8 FMOE configs for EP=4 + fused shared expert (MI355x)#3529
Open
omirosh wants to merge 1 commit into
Open
[tune] GLM-4.7-FP8 FMOE configs for EP=4 + fused shared expert (MI355x)#3529omirosh wants to merge 1 commit into
omirosh wants to merge 1 commit into
Conversation
Adds FP8 fused-MoE tuning entries for GLM-4.7 running with Expert Parallel=4 plus the fused shared-expert (FSE) path introduced in vllm-project/vllm#44313. Each EP=4 rank carries 160/4 routed experts plus 1 fused shared expert (expert=41, topk=10) at cu_num=256, model_dim=5120, inter_dim=1536. - aiter/configs/model_configs/glm47_fp8_untuned_fmoe.csv: append 20 token rows for the new expert=41, topk=10 block. - aiter/configs/model_configs/glm47_fp8_tuned_fmoe.csv: append the corresponding 20 tuned entries. Co-authored-by: Cursor <[email protected]>
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional FP8 fused-MoE tuning coverage for GLM-4.7 in the model-specific config set, targeting the EP=4 + fused shared-expert (FSE) path by extending the expert=41, topk=10 shape block and ensuring both untuned and tuned CSVs contain corresponding entries.
Changes:
- Extended
glm47_fp8_untuned_fmoe.csvwith a newexpert=41, topk=10block covering token sizes from 1 through 32768 (20 rows). - Extended
glm47_fp8_tuned_fmoe.csvwith the corresponding 20 tuned entries (kernel selections + timings) for the same shapes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| aiter/configs/model_configs/glm47_fp8_untuned_fmoe.csv | Adds new untuned shape rows for expert=41, topk=10 to drive tuning/lookup coverage. |
| aiter/configs/model_configs/glm47_fp8_tuned_fmoe.csv | Adds the matching tuned kernel configs for expert=41, topk=10 shapes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds FP8 fused-MoE tuning entries for GLM-4.7 running with Expert Parallel = 4
plus the fused shared-expert (FSE) path (introduced in vllm-project/vllm#44313 ).
Changes
aiter/configs/model_configs/glm47_fp8_untuned_fmoe.csv: append 20rows for the new
expert=41, topk=10block.aiter/configs/model_configs/glm47_fp8_tuned_fmoe.csv: append thecorresponding 20 tuned entries
Test plan
picked up via
aiter.tuned_moelookup and that the cached kernelconfigs are used (no fallback warnings).
Made with Cursor