Restructure half.hpp and hip_fp16.h includes #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Oct 7, 2024
- Add half/half.hpp for HOST and hip/hip_fp16.h for HIP in just 1 common header (rppdefs.h)
- Remove half.hpp includes in all remaining RPP tensor API and tensor test suite files to address issue RPP: #define common headers only in single file. #434
> Remove the Repeating half includes
Move half.hpp to Common Header and Remove from Other Files
Collaborator
|
@r-abishek failing CI |
Error:
" In file included from /opt/rocm-6.3.0/share/rpp/test/HIP/Tensor_hip.cpp:33:
2989
4: /opt/rocm-6.3.0/share/rpp/test/HIP/../rpp_test_suite_image.h:53:14: error: typedef redefinition with different types ('half' (aka '__half') vs 'halfhpp' (aka 'half_float::half'))
2990
4: 53 | typedef half Rpp16f;
2991
4: | ^
2992
4: /opt/rocm/include/rpp/rppdefs.h:41:17: note: previous definition is here
2993
4: 41 | typedef halfhpp Rpp16f;
2994
4: | ^
2995
4: 1 error generated when compiling for gfx942."
rrawther
approved these changes
Nov 15, 2024
LakshmiKumar23
approved these changes
Nov 15, 2024
kiritigowda
approved these changes
Nov 27, 2024
HazarathKumarM
referenced
this pull request
in HazarathKumarM/rpp
Mar 19, 2025
* Add includes for half in rpp_defs
> Remove the Repeating half includes
* revert changes in old test suite
* Update rpp_test_suite_image.h to fix redefinition error
Error:
" In file included from /opt/rocm-6.3.0/share/rpp/test/HIP/Tensor_hip.cpp:33:
2989
4: /opt/rocm-6.3.0/share/rpp/test/HIP/../rpp_test_suite_image.h:53:14: error: typedef redefinition with different types ('half' (aka '__half') vs 'halfhpp' (aka 'half_float::half'))
2990
4: 53 | typedef half Rpp16f;
2991
4: | ^
2992
4: /opt/rocm/include/rpp/rppdefs.h:41:17: note: previous definition is here
2993
4: 41 | typedef halfhpp Rpp16f;
2994
4: | ^
2995
4: 1 error generated when compiling for gfx942."
---------
Co-authored-by: HazarathKumarM <[email protected]>
Co-authored-by: Kiriti Gowda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.