[action/manual_trigger] fix mannual trigger to create dist zip file #10244
+48
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add fixed code * add fixed code
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the manual trigger workflow so that a distribution zip file (dist.zip) can be created and downloaded. Key changes include updating various GitHub Actions workflow configuration files to change the checkout and setup‐python actions from previous version tags (e.g., @v4 or @V3) to using @main, along with a modification of the scons commands in the manual_dist workflow.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/utest_auto_run.yml | Updated checkout action from @v4 to @main |
| .github/workflows/manual_trigger_update_all.yml | Updated checkout and setup-python actions from version tag to @main |
| .github/workflows/manual_trigger_scons_fail_bsp_all.yml | Updated checkout and setup-python actions to @main |
| .github/workflows/manual_trigger_scons_except_STM32_all.yml | Updated checkout action to @main |
| .github/workflows/manual_dist.yml | Updated checkout and setup-python actions to @main; modified scons commands |
| .github/workflows/manual_bsp_build.yml | Updated checkout and setup-python actions to @main |
| .github/workflows/compile_bsp_with_drivers.yml | Updated checkout action to @main |
| .github/workflows/bsp_buildings.yml | Updated checkout action twice to @main in different steps |
| .github/workflows/action_utest.yml | Updated checkout action to @main |
| .github/workflows/action_tools.yml | Updated checkout action to @main |
| .github/workflows/action_runner.yml | Updated checkout action (from @V3) to @main |
Files not reviewed (1)
- .github/workflows/manual_trigger_scons_STM32_all.yml: Language not supported
Comments suppressed due to low confidence (4)
.github/workflows/manual_trigger_update_all.yml:48
- Using actions/setup-python@main can introduce unexpected updates. It's recommended to use a specific version (e.g., @V3) to maintain a consistent environment.
- uses: actions/setup-python@main
.github/workflows/manual_trigger_scons_fail_bsp_all.yml:107
- Consider using a specific version for actions/setup-python (e.g., @V3) instead of @main to maintain a stable and predictable setup.
- uses: actions/setup-python@main
.github/workflows/manual_dist.yml:58
- It's recommended to use a versioned action for setup-python (e.g., @V3) instead of @main to ensure a consistent Python environment.
- uses: actions/setup-python@main
.github/workflows/manual_bsp_build.yml:59
- Using a versioned setup-python action (such as @V3) rather than @main can help ensure consistent behavior in your workflow.
- uses: actions/setup-python@main
|
ci 挂了 |
不是这个原因，其他原因，arduino软件包那边有更新 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
修复手动生成编译的error
你的解决方案是什么 (what is your solution)
修复action中的dist方案
现在可以手动触发，然后生成dist.zip的文件，该zip文件可以直接下载编译。
请提供验证的bsp和config (provide the config and bsp)
https://github.com/supperthomas/rt-thread/actions/runs/14861039291/job/41725700285
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up