Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add tenancy support #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 21, 2023
Merged

Add tenancy support #8

merged 5 commits into from
Mar 21, 2023

Conversation

masonjlegere
Copy link
Contributor

@masonjlegere masonjlegere commented Mar 17, 2023 •
edited
Loading

Description

Adds support for the the testing GitHub action to support multi-tenancy test execution. Node version for execution bumped to 16 for my sanity.

Verification

Created dummy test in the prodca Hub and executed against this action using

jobs:
  run_api_test:
    runs-on: ubuntu-latest
    name: Execute RapidAPI API Tests
    steps:
    - name: Execute Tests
      id: tstExec
      uses: RapidAPI/gh-api-testing-trigger@add-tenancy-support
      with:
        test: 'test_bbdc3526-0073-432a-9d30-a8629596c08d'
        location: 'AWS-US-EAST-1'
        tenant: "rapidapi.hub-ca.rapidapi.com"
    - name: Show Results
      run: echo "The test took ${{ steps.tstExec.outputs.time }}ms to run"; echo "The test result was ${{ steps.tstExec.outputs.computedStatus }}"; echo "View Report - ${{ steps.tstExec.outputs.reportUrl }}"

Screen Shot 2023-03-17 at 3 08 25 PM

Screen Shot 2023-03-17 at 3 11 53 PM

Ready for Code Review Checklist

  • Includes unit tests
  • Includes related documentation

@masonjlegere
Copy link
Contributor Author

^ We need to remove PR verification checks for public repositories -- will report to team

@masonjlegere masonjlegere marked this pull request as ready for review March 17, 2023 22:12
@masonjlegere masonjlegere added the enhancement New feature or request label Mar 17, 2023
masonjlegere
masonjlegere commented Mar 17, 2023
View reviewed changes
.github/release.yaml
@@ -0,0 +1,22 @@
changelog:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add for the future to get labels for PRs

a-cong
a-cong approved these changes Mar 17, 2023
View reviewed changes
LMS007
LMS007 suggested changes Mar 17, 2023
View reviewed changes
Copy link

@LMS007 LMS007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im good to make these changes, but we do have to update the README too. This is a public repo so we gotta be lock step with the documentation

README.md
@@ -44,6 +45,10 @@ jobs:
### `environment`
The environment you want to run the test in. If you don't use environment omit this parameter

### `tenant`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the README too, could be in a follow up PR but it would be nice to have a MT example url there.. something like this

US: https://acme.hub.rapidapi.com
CA: https://acme.hub-ca.rapidapi.com
EU: https://acme.hub-eu.rapidapi.com

package.json
"version": "0.0.3",
"description": "",
"version": "0.0.4",
"description": "Executes RapidAPI tests as a GitHub action",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@masonjlegere masonjlegere requested a review from LMS007 March 17, 2023 23:13
masonjlegere
masonjlegere commented Mar 17, 2023
View reviewed changes
README.md
## Outputs

### `time`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown linting changes

LMS007
LMS007 approved these changes Mar 21, 2023
View reviewed changes
Copy link

@LMS007 LMS007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@masonjlegere masonjlegere merged commit 9a43ccf into master Mar 21, 2023
@masonjlegere masonjlegere deleted the add-tenancy-support branch March 21, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMS007 LMS007 LMS007 approved these changes

@a-cong a-cong a-cong approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masonjlegere @LMS007 @a-cong