Adds orsopy integration for .ort files and ORSO models
#131
Conversation
.ort file reader.ort files and ORSO models
|
@DrPaulSharp to address your comment about substrate/liquid: the only thing |
|
Ok, that makes sense. My concern though is that in |
|
@DrPaulSharp decided to not bother creating the whole project, which makes most of the review points fixed by being no longer relevant. see the notebook for a good idea of what I suggest as a better way of doing things (as discussed in the meeting). One problem I'm noticing is that the data in the notebook example isn't fit very well - this isn't a good look, but it is also weird data. not sure if you can suggest anything there? |
There was a problem hiding this comment.
This is looking really good and I think is the right approach to taking in this data.
As discussed, let's raise the data fit in the next project meeting and work out where to go from there.
I've one more thing I'd like you to do, could you write __str__ method for the ORSOProject and ORSOSample classes to print them out in tables like a cut down Project. How do you think we should present the model in these classes?
This PR adds functionality to read
.ortdata and models. Fixes #104The interface is through one function and one class:
RATapi.utils.orso.orso_model_to_rat, which turns an ORSO model description (given as either an orsopySampleModelor a string) into an ORSOSample dataclass, which gives bulk in and bulk out data as well as a list of layers in the model and the parameters required to define them.RATapi.utils.orso.ORSOProject, which contains all data from an .ort file. This can then be put into a project as required.