Fix chain plots crash if chains are smaller than maxpoints
#154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the chain plots crash if
maxpoints
is larger than the length of the chain. This is because we use askip
variable:skip = floor(nsimulations / maxpoints)
which gives us spacing so that the sampled points in the plot are evenly distributed across the chain. However, if
nsimulations < maxpoints
, thenskip
will be 0, which causes a crash when we try to use it for a range skip.We fix this by replacing the above line with
skip = max(floor(nsimulations / maxpoints), 1)
so that
skip
is set to 1 (i.e. the entire chain is plotted) whennsimulations < maxpoints
.To reproduce: