Fixes failing test on python 3.13 and ensure macOS uses 3.12 #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d0c827 to
0bb9c1e
Compare
|
just trying to run with 3.13 to see what happens... i was under the impression that actions/setup-python grabbed the binary remotely so i don't see why it wouldn't support 3.13? (it even has 3.13 as an example in the readme!) |
The problem was I set the python version to 3.x and last week it was downloading 3.12 on Windows and Linux. It might be fixed now or maybe just the 3.x syntax was broken not sure |
alexhroom
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a workaround for MacOS runner ignoring the given python version for the test and fixed a test that was failing on 3.13. The python version is still capped at 3.12 because ubuntu and windows runner are still stuck at 3.12