Tweak Lambertian reflection description #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
books/RayTracingInOneWeekend.html
Outdated
| objects is the _Lambertian_ distribution, which scatters reflected rays in a manner that is | ||
| propertional to $\cos (\phi)$, where $\phi$ is the angle between the reflected ray and the surface | ||
| normal. This means that a ray is most likely to scatter in directions close to the normal, and less | ||
| likely to scatter in directions more tangent to the surface. This distribution is notably no longer |
There was a problem hiding this comment.
"This means that a ray is more likely to scatter in direction close to the normal, and less likely to scatter in directions close to the surface"
Alternatively:
""This means that a ray is more likely to scatter in direction close to the normal, and less likely to scatter in directions more tangent to the normal"
?
There's a couple of undesirable/awkward English A-B contrasts
"most" -> "less"
"close to the normal" -> "tangent to the surface"
Neither of my alts are perfect, not sure what is best here
There was a problem hiding this comment.
Tweaked some more.
My main object was to address some confusing wording of the last sentence of the first paragraph, but I also massed other parts of this paragraph.
f733686 to
1f14534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main object was to address some confusing wording of the last sentence of the first paragraph, but I also massed other parts of this paragraph.