Refactor pixel subsampling #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplify pixel sampling to make the sampling functions simpler and agnostic about their use as pixel sampling functions. Now they sample an idealized unit square or disk and are ignorant about image components. - pixel_sample_xxx() functions renamed to sample_xx(). - Rename pixel_sample_scale to pixel_samples_scale. - Reworded some comments for clarity. - I really wish I could have come up with a better rename for `sqrt_spp` and `recip_sqrt_spp`, but I've been unable to think of anything better.
armansito
approved these changes
Mar 10, 2024
There was a problem hiding this comment.
Looks good. I left a couple of suggestions that I don't feel particularly strong about, so feel free to ignore them.
- I really wish I could have come up with a better rename for sqrt_spp and recip_sqrt_spp, but I've been unable to think of anything better.
I think these names are fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqrt_sppandrecip_sqrt_spp, but I've been unable to think of anything better.