Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix listing 58 syntax error #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2020
Merged

Fix listing 58 syntax error #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Change Log -- Ray Tracing in One Weekend
### In One Weekend
- Change: Wrote brief explanation waving away negative t values in initial normal sphere
- Fix: Catch cases where `lambertian::scatter()` yields degenerate scatter rays (#619)
- Fix: Syntax error in listing 58 (Dielectric material class with reflection) (#768)

### The Next Week
- Fix: Catch cases where `lambertian::scatter()` yields degenerate scatter rays (#619)
Expand Down
2 changes: 1 addition & 1 deletion books/RayTracingInOneWeekend.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2576,7 +2576,7 @@
bool cannot_refract = refraction_ratio * sin_theta > 1.0;
vec3 direction;

if (cannot_refract) {
if (cannot_refract)
direction = reflect(unit_direction, rec.normal);
else
direction = refract(unit_direction, rec.normal, refraction_ratio);
Expand Down