Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't access rows of empty table#7750

Merged
ben-schwen merged 2 commits into
masterfrom
empty-dogroups
May 21, 2026
Merged

Don't access rows of empty table#7750
ben-schwen merged 2 commits into
masterfrom
empty-dogroups

Conversation

@MichaelChirico
Copy link
Copy Markdown
Member

Closes #7749

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (188dd7b) to head (b17a1c9).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7750      +/-   ##
==========================================
- Coverage   99.04%   99.04%   -0.01%     
==========================================
  Files          87       87              
  Lines       17065    17064       -1     
==========================================
- Hits        16902    16901       -1     
  Misses        163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

  • HEAD=empty-dogroups much slower for as.data.table.array improved in #7019
  • HEAD=empty-dogroups slower P<0.001 for isoweek improved in #7144
    Comparison Plot

Generated via commit b17a1c9

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 52 seconds
Installing different package versions 47 seconds
Running and plotting the test cases 6 minutes and 6 seconds

Comment thread src/dogroups.c Outdated
@ben-schwen ben-schwen merged commit 26bb18e into master May 21, 2026
9 of 13 checks passed
@ben-schwen ben-schwen deleted the empty-dogroups branch May 21, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VECTOR_ELT issues with empty data.tables with R 4.6.

3 participants