feat: Add support for ARJ archives #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9430c4 to
e1225f4
Compare
|
I tested it against example ARJ archives from:
|
|
For good measure, I created my own ARJ archive and added an integration test with it at c24c501. For completeness, this is how the file containing the ARJ archive was created: echo "<...>" > secret.txt
arj a -jm1 example.arj secret.txt
dd if=/dev/rand of=arj.bin bs=256 count=1
dd if=example.arj of=arj.bin bs=1 seek=13 conv=notrunc |
c2d7155 to
c24c501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintroduces support for ARJ archives to the rust rewrite.