Fix issues that GroupBy and Sample doesn't call 'unsubscribe' and also NPE when the key is null in GroupBy #1959
Conversation
|
Find two more bugs:
|
|
Fixed them in this PR. |
There was a problem hiding this comment.
There is a self member variable which also points to this.
There was a problem hiding this comment.
This will unsubscribe the downstream. I suggest instead having child.add(sampler); after L52.
There was a problem hiding this comment.
I haven't had a chance to try this code yet, but I want to make sure this doesn't break the backpressure functionality where this operator requests Long.MAX_VALUE up.
There was a problem hiding this comment.
This will unsubscribe the downstream. I suggest instead having child.add(sampler); after L52.
Could you elaborate? I think unsubscribe the downstream would be OK for this operator.
There was a problem hiding this comment.
I haven't had a chance to try this code yet, but I want to make sure this doesn't break the backpressure functionality where this operator requests Long.MAX_VALUE up.
sample with time does not support backpressure as it uses time to control data flow, right?
There was a problem hiding this comment.
I feel some redundancy here. Maybe it is worth reviewing the other counters and state indicators.
|
This PR contains a lot. I will split it to 3 PRs. |
Fix #1958