Thanks to visit codestin.com
Credit goes to github.com

Skip to content

3.x: Add NonNull & SafeVarargs annotations + validator #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2019
Merged

3.x: Add NonNull & SafeVarargs annotations + validator #6791

merged 1 commit into from
Dec 24, 2019

Conversation

akarnokd
Copy link
Member

This PR cleans up the main classes:

  • Add missing @NonNull annotations
  • Add missing @SafeVarargs annotations
  • Add validator code that scans the sources to verify the annotations are present
  • Remove unnecessary @SuppressWarnings annotations
  • Fix a few type arguments.

Related #6766

@akarnokd akarnokd added Cleanup 3.x Java 8 Issues and PRs related to Java 8 support labels Dec 23, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 23, 2019
@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #6791 into 3.x will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##                3.x   #6791      +/-   ##
===========================================
- Coverage     98.27%   98.2%   -0.08%     
+ Complexity     6287    6286       -1     
===========================================
  Files           696     696              
  Lines         45390   45395       +5     
  Branches       6233    6233              
===========================================
- Hits          44607   44579      -28     
- Misses          273     290      +17     
- Partials        510     526      +16
Impacted Files Coverage Δ Complexity Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 577 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <100%> (ø) 537 <30> (ø) ⬇️
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 177 <18> (ø) ⬇️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 151 <10> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <100%> (ø) 120 <4> (ø) ⬇️
...n/java/io/reactivex/rxjava3/core/Notification.java 93.93% <100%> (ø) 22 <1> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 83.8% <0%> (-11.27%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 92.85% <0%> (-3.18%) 2% <0%> (ø)
...eactivex/rxjava3/processors/BehaviorProcessor.java 96.58% <0%> (-2.44%) 51% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 91.57% <0%> (-2.11%) 3% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b92c6f...25dcda6. Read the comment docs.

@akarnokd akarnokd merged commit b57169b into ReactiveX:3.x Dec 24, 2019
@akarnokd akarnokd deleted the Jdk8Cleanup_1222 branch December 24, 2019 09:18
@akarnokd akarnokd mentioned this pull request Dec 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x Cleanup Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@akarnokd