Thanks to visit codestin.com
Credit goes to github.com

Skip to content

3.x: [Java 8] Add flattenStreamAsX to Maybe/Single #6805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2019
Merged

3.x: [Java 8] Add flattenStreamAsX to Maybe/Single #6805

merged 2 commits into from
Dec 28, 2019

Conversation

akarnokd
Copy link
Member

Add

  • Maybe.flattenStreamAsFlowable
  • Maybe.flattenStreamAsObservable
  • Single.flattenStreamAsFlowable
  • Single.flattenStreamAsObservable

Related #6776

(In addition, adjust the validators to appreciate the new patterns.)

Marbles:

image
image
image
image

@akarnokd akarnokd added Enhancement 3.x Java 8 Issues and PRs related to Java 8 support labels Dec 28, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 28, 2019
@akarnokd akarnokd mentioned this pull request Dec 28, 2019
Closed
@codecov
Copy link

codecov bot commented Dec 28, 2019 •
edited
Loading

Codecov Report

Merging #6805 into 3.x will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6805      +/-   ##
============================================
- Coverage     98.27%   98.22%   -0.06%     
- Complexity     6372     6381       +9     
============================================
  Files           711      715       +4     
  Lines         46243    46496     +253     
  Branches       6329     6371      +42     
============================================
+ Hits          45446    45670     +224     
- Misses          282      299      +17     
- Partials        515      527      +12
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 553 <0> (ø) ⬇️
...a3/internal/jdk8/MaybeFlattenStreamAsFlowable.java 100% <100%> (ø) 2 <2> (?)
.../internal/jdk8/MaybeFlattenStreamAsObservable.java 100% <100%> (ø) 2 <2> (?)
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <100%> (ø) 179 <2> (+2) ⬆️
...rc/main/java/io/reactivex/rxjava3/core/Single.java 100% <100%> (ø) 153 <2> (+2) ⬆️
...3/internal/jdk8/SingleFlattenStreamAsFlowable.java 100% <100%> (ø) 2 <2> (?)
...internal/jdk8/SingleFlattenStreamAsObservable.java 100% <100%> (ø) 2 <2> (?)
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 89.9% <0%> (-8.26%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 88.88% <0%> (-5.56%) 2% <0%> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0%> (-3.97%) 2% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f8e6d...f455cd2. Read the comment docs.

@akarnokd akarnokd merged commit 34f381c into ReactiveX:3.x Dec 28, 2019
@akarnokd akarnokd deleted the FlattenStreamAs3x branch December 28, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3.x Enhancement Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@akarnokd