3.x: Fix recent groupBy tests sometimes failing with MBE #6994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #6994 +/- ##
=========================================
Coverage 99.52% 99.53%
- Complexity 6669 6671 +2
=========================================
Files 742 742
Lines 47270 47270
Branches 6373 6373
=========================================
+ Hits 47045 47049 +4
+ Misses 105 100 -5
- Partials 120 121 +1 Continue to review full report at Codecov.
|
|
The matrix passed so https://travis-ci.org/github/akarnokd/RxJava3_BuildMatrix/builds/689534225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests can fail with
MissingBackpressureExceptionbecause groups may not complete fast enough soflatMapcan request more groups in time. This doesn't happen consistently but could fail the test on CI. The workaround is to allow any termination, not just normal completion. The reasoning is that the aim of the tests were to verify the operator doesn't hang.The underlying complication is that whenever there is an item replenishment, any subsequent item can result in a fresh group being created. If the concurrency level of
flatMapis not high enough, this will result in a MBE and the sequence terminates.