Conversation
…orGet op. Return an error for DAGRUN command with no ops.
…ia test module (passed valgrind)
test LLAPI (with/without errors) via test module (passed valgrind). Persist not checked (require enablement).
…Error) + tests via test module.
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
==========================================
+ Coverage 72.31% 74.16% +1.84%
==========================================
Files 37 39 +2
Lines 5917 6081 +164
==========================================
+ Hits 4279 4510 +231
+ Misses 1638 1571 -67
Continue to review full report at Codecov.
|
…Context dict is not thread safe for reading operations)
in parsing modelrun/script run command (currently assume that the access is only from redis main thread)
DvirDukhan
reviewed
Jan 17, 2021
…ith an error. this is the one that is returned in LLAPI. - Add macro to redisai.h to resolve double includes issues. - Update arr.h, support creating dynamic arrays on stack (in addition). - PR fixes, test module refactor
- Added tests for errors in dag parsing. - Bug fix in parse timeout
DvirDukhan
reviewed
Jan 19, 2021
DvirDukhan
approved these changes
Jan 21, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#456
Add the LLAPI for running a DAG.