Introduce AI.DAGEXECUTE command, AI.DAGRUN is now deprecated.#723
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 78.93% 79.30% +0.36%
==========================================
Files 48 48
Lines 7343 7474 +131
==========================================
+ Hits 5796 5927 +131
Misses 1547 1547
Continue to review full report at Codecov.
|
…sing + add tests. Fix "validateKeysInShard" to work on a single shard in enterprise.
DvirDukhan
suggested changes
May 7, 2021
DvirDukhan
left a comment
There was a problem hiding this comment.
looks good
mainly cosmetics changes
please split tests_dag.py into several test files so it will be easier to track the logic
…sing + add tests. Fix "validateKeysInShard" to work on a single shard in enterprise.
DvirDukhan
suggested changes
May 9, 2021
| env.assertEqual(ret, b'OK') | ||
|
|
||
| command = "AI.DAGEXECUTE LOAD 2 persisted_tensor_1{1} persisted_tensor_2:{1}" \ | ||
| " PERSIST 1 volatile_tensor_persisted |> " \ |
Collaborator
Author
There was a problem hiding this comment.
good catch! found a bug - fixing
- Rename test_auxiliaries to tests_setup - Changes in documentation.
DvirDukhan
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new command according to the new design, no actual change in semantics.
The main difference between AI.DAGRUN and AI.DAGEXECUTE is: