Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Let ai.scriptget and ai.modelget commands run successfully without optional args#791

Merged
alonre24 merged 7 commits into
masterfrom
align_script_get_command
Jul 12, 2021
Merged

Let ai.scriptget and ai.modelget commands run successfully without optional args#791
alonre24 merged 7 commits into
masterfrom
align_script_get_command

Conversation

@alonre24

@alonre24 alonre24 commented Jun 17, 2021

Copy link
Copy Markdown
Collaborator

Align script get and model get command, so it will return both source/blob and meta if no optional argument is specified.
This PR also contains some documentation corrections for the new script commands.

@alonre24 alonre24 requested a review from DvirDukhan June 17, 2021 16:25
@codecov

codecov Bot commented Jun 17, 2021

Copy link
Copy Markdown

Codecov Report

Merging #791 (81b528b) into master (d74d953) will increase coverage by 0.06%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   79.95%   80.01%   +0.06%     
==========================================
  Files          53       53              
  Lines        8037     8032       -5     
==========================================
+ Hits         6426     6427       +1     
+ Misses       1611     1605       -6     
Impacted Files Coverage Δ
src/redisai.c 86.99% <96.00%> (+1.07%) ⬆️
...c/serialization/RDB/decoder/current/v3/decode_v3.c 65.38% <0.00%> (-2.75%) ⬇️
src/backends/onnxruntime.c 77.88% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c2b59...81b528b. Read the comment docs.

@DvirDukhan DvirDukhan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comments to the if confitions or have some kind of format enumt

Comment thread src/redisai.c Outdated
DvirDukhan
DvirDukhan previously approved these changes Jun 22, 2021
@alonre24 alonre24 force-pushed the align_script_get_command branch from 6986bde to 81b528b Compare July 11, 2021 15:22
@alonre24 alonre24 changed the title Adjust ai.scriptget command Let ai.scriptget and ai.modelget commands run successfully without optional args Jul 11, 2021
@alonre24 alonre24 requested a review from DvirDukhan July 11, 2021 15:28
@alonre24 alonre24 merged commit 10d857f into master Jul 12, 2021
@alonre24 alonre24 deleted the align_script_get_command branch July 12, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants