fixed invalid delete of outputs after execution error in TF#852
Merged
Conversation
alonre24
reviewed
Oct 13, 2021
alonre24
left a comment
Collaborator
There was a problem hiding this comment.
Can you add a test for it?
alonre24
reviewed
Oct 13, 2021
| env.assertEqual(ret, b'OK') | ||
| con.execute_command('AI.TENSORSET', 'my_str_tensor{1}', 'STRING', 4, 'BLOB', "how do I extract keys from a dict into a list?\x00debug public static void main(string[] args) {...}\x00should I use def main()\x00type hinting for list?\x00") | ||
| env.assertEqual(ret, b'OK') | ||
| check_error(env, con, 'AI.MODELEXECUTE', 'm{1}', 'INPUTS', 1, 'my_str_tensor{1}', 'OUTPUTS', 1, 'foo{1}') No newline at end of file |
Collaborator
There was a problem hiding this comment.
Can you document what is the expected error?
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
==========================================
+ Coverage 79.97% 81.33% +1.35%
==========================================
Files 53 56 +3
Lines 8009 8185 +176
==========================================
+ Hits 6405 6657 +252
+ Misses 1604 1528 -76
Continue to review full report at Codecov.
|
alonre24
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a model fails to execute on TF, the excution returns without outputs. On clean it causes to crash