Fix global threads count var update#923
Merged
Merged
Conversation
… creating onnx global structure (WIP)
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
+ Coverage 81.30% 81.75% +0.44%
==========================================
Files 54 54
Lines 8201 8220 +19
==========================================
+ Hits 6668 6720 +52
+ Misses 1533 1500 -33
Continue to review full report at Codecov.
|
DvirDukhan
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the global variable that indicates the number of RedisAI background threads from the main thread to ensure synchronization upon creating the global ONNX structure. When ONNX model is loaded via AI.MODELSTORE command for the first time, it triggers loading of ONNX backend and allocation of the global array, whose size equals to the number of background threads. Previously, the BG threads themselves where in charge of updating this counter, and there was a race condition that may lead to server crash - https://redislabs.atlassian.net/browse/MOD-3262. This PR is the fix for that issue.