-
Notifications
You must be signed in to change notification settings - Fork 337
MOD-11445 fixing alpine build #1393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gabsow
wants to merge
17
commits into
master
Choose a base branch
from
tomg-fixing-alpine-build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration for refactoring" This reverts commit d6db932.
- Use escaped dollar sign for uname command in shell conditional - Reorder conditions to check Alpine first for better readability - This should resolve the 'syntax error: unexpected end of file' in CI
- Replace complex shell conditionals with simple script-based approach - Add extract_symbols_safe.sh script to handle Alpine ARM64 detection - Simplify Makefile to avoid shell syntax errors in CI - Alpine ARM64 now properly skips debug symbol extraction - Resolves segmentation fault and shell syntax issues
- Add objcopy availability check to handle containerized builds - Fix issue where CI runs on Ubuntu host but builds in Alpine container - Script now detects Alpine builds even when host OS is different - Prevents 'objcopy: command not found' errors in CI - Maintains compatibility with all other platforms
- Consolidate symbol extraction logic into single script - Script now handles both Alpine detection and symbol extraction - Eliminates complex Makefile logic that was causing objcopy conflicts - Alpine ARM64 properly skips debug extraction, other platforms extract normally - Resolves all objcopy-related build failures in CI - Build now completes successfully on Alpine ARM64
- Remove trailing whitespace from line continuation - Fix formatting to match project style guidelines - Resolves linter failures in CI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1393 +/- ##
=======================================
Coverage 79.28% 79.28%
=======================================
Files 15 15
Lines 3707 3707
=======================================
Hits 2939 2939
Misses 768 768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Skip debug symbol extraction on all Alpine builds, not just ARM64 - Skip shared API export on all Alpine builds to prevent crashes - Update detection logic to handle Alpine x86_64 RAMP packaging failures - Update unit tests to reflect broader Alpine detection - Resolves segmentation faults during RAMP packaging on Alpine x86_64
- Remove Alpine-specific shared API export skipping from Rust code - Keep full RedisJSON functionality enabled on Alpine - Shell script fix for debug symbol extraction is sufficient - Preserves inter-module communication capabilities - Targeted fix addresses the actual root cause (debug symbol confusion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.