Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix #151 Don't return deleted docs on qget #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 18, 2020
Merged

fix #151 Don't return deleted docs on qget #179

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
10b9e98
fix #151 Don't return deleted docs on qget
gkorland May 6, 2020
4a0bdd1
fix create_field api usage
gkorland May 10, 2020
fb82bf1
Fix according to code reivew
gkorland May 10, 2020
25ac923
Merge branch 'master' into deleted_docs
gkorland May 18, 2020
e5f9042
Merge branch 'master' into deleted_docs
gkorland May 18, 2020
496a5d8
fix build
gkorland May 18, 2020
0557990
rename variable
gkorland May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rename variable
  • Loading branch information
@gkorland
gkorland committed May 18, 2020
commit 0557990f3823dcbe2ea24ec7187751319922483e
8 changes: 4 additions & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ fn json_set(ctx: &Context, args: Vec<String>) -> RedisResult {
match (current, set_option) {
(Some(ref mut doc), ref op) => {
if doc.set_value(&value, &path, op, format)? {
if let Some(index) = value_index {
index::add_document(&key, &index.index_name, &doc)?;
if let Some(value_index) = value_index {
index::add_document(&key, &value_index.index_name, &doc)?;
}
ctx.replicate_verbatim();
REDIS_OK
Expand All @@ -139,12 +139,12 @@ fn json_set(ctx: &Context, args: Vec<String>) -> RedisResult {
if path == "$" {
redis_key.set_value(&REDIS_JSON_TYPE, doc)?;

if let Some(index) = value_index {
if let Some(value_index) = value_index {
// FIXME: We need to get the value even though we just set it,
// since the original doc is consumed by set_value.
// Can we do better than this?
let doc = redis_key.get_value(&REDIS_JSON_TYPE)?.unwrap();
index::add_document(&key, &index.index_name, doc)?;
index::add_document(&key, &value_index.index_name, doc)?;
}
ctx.replicate_verbatim();
REDIS_OK
Expand Down