Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Print git sha to module log on init #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 8, 2021
Merged

Print git sha to module log on init #520

merged 4 commits into from
Nov 8, 2021

Conversation

oshadmi
Copy link
Collaborator

@oshadmi oshadmi commented Nov 4, 2021

No description provided.

@oshadmi oshadmi marked this pull request as ready for review November 7, 2021 22:03
@oshadmi oshadmi requested a review from rafie November 7, 2021 22:03
rafie
rafie reviewed Nov 8, 2021
View reviewed changes
build.rs Outdated

fn main() {
// Expose GIT_SHA env var
let gitsha = Command::new("git").args(&["rev-parse", "HEAD"]).output();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

["rev-parse", "--short", "HEAD"]

@rafie
Copy link
Contributor

rafie commented Nov 8, 2021

We can also add git rev-parse --abbrev-ref HEAD for GIT_BRANCH.

@oshadmi oshadmi merged commit decd330 into master Nov 8, 2021
@oshadmi oshadmi deleted the omer_gitsha branch November 8, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeirShpilraien MeirShpilraien Awaiting requested review from MeirShpilraien

1 more reviewer

@rafie rafie rafie approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oshadmi @rafie