Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@galcohen-redislabs
Copy link
Collaborator

No description provided.

@galcohen-redislabs galcohen-redislabs changed the title Update LibMR submodule to latest commits RED-175184 Update LibMR submodule to latest commits Nov 4, 2025
@galcohen-redislabs galcohen-redislabs merged commit 7c8a644 into master Nov 4, 2025
23 checks passed
@galcohen-redislabs galcohen-redislabs deleted the gal-175184-use-latest-libmr branch November 4, 2025 20:07
galcohen-redislabs added a commit that referenced this pull request Nov 6, 2025
gabsow added a commit that referenced this pull request Nov 6, 2025
* compatible_redis_version = 99.99

* add rhel9 arm (#1782)

* MOD-000: fix commands.json (#1785)

* adding cherry picking script (#1790)

* adding cherry picking script

* change to cherry-pick -x

* MOD-11322 Support Atomic Slots Migration (#1784)

* MOD-11322 Support Atomic Slots Migration

Initial work: filtering of keys during queries. Temporarily based on two side branches:
- redis: `https://github.com/tezc/redis/tree/cluster-asm`
- modules sdk: `https://github.com/tezc/RedisModulesSDK/tree/cluster-asm`

* Some cleanups

* Added a test (without data integrity checks yet)

* ooops

* Fixed do-i-own-key logic re/ Ozan's CR

* Update src/module.c

Co-authored-by: Ozan Tezcan <[email protected]>

* Added slots table to the tests utils

* Don't show progress in tests because the progress bar crashes the python script for some weird reason

* Align with the new redis module names

* Added test with data

* Added a test of queries under migrations

* Update LibMR and add Python 3.7+ compatibility

- Update deps/LibMR submodule to 93b1ace (Align names with latest redis)
  - Includes ASM API adjustments (MOD-11322)
  - Includes logic fixes for hslot ownership
- Update deps/RedisModulesSDK
- Fix Python 3.7+ compatibility in test_asm.py
  - Replace Python 3.10+ type hints (str | None, set[T]) with typing module (Optional[str], Set[T])
  - Replace Python 3.8+ walrus operator (:=) with traditional for loop
- Format code in common.h, indexer.c, module.c

---------

Co-authored-by: Ozan Tezcan <[email protected]>
Co-authored-by: Tom Gabsow <[email protected]>

* Fix ARM workflow: add fail-fast: false to match x86 behavior

Without this setting, one OS failure (like bionic) cancels all other
pending OS builds (focal, jammy, rocky9, azurelinux3). The x86 workflow
already has this setting, so all OS variants run independently.

* MOD-11322 Register also for the new "key_trimmed" event (#1794)

* MOD-12146 Less stress on ASM tests under valgrind (#1796)

* Update LibMR submodule to latest commits (#1801)

* MOD-12238 fix clang version error handling (#1799)

* clang blocks capture by reference

* tests

* RED-175184 Fix build on macOS 15 (Sequoia) with CMake 4.x (#1805)

* Fix build on macOS 15 (Sequoia) with CMake 4.x

Update submodules to support building on macOS 15 (Sequoia) with CMake 4.x:

- cpu_features: Update CMake minimum version from 3.0 to 3.5
  (CMake 4.x no longer supports version 3.0 requirement)

- readies: Add support for macOS 15 (Sequoia) detection
  (Fixes OSX_MIN_SDK_VER being undefined, which caused
  -mmacosx-version-min= to have no value)

These changes enable successful compilation of RedisTimeSeries
on macOS 15.6.1 with CMake 4.1.1.

* Update cpu_features submodule to point to fix/cmake-version-requirement branch

This ensures the CMake 3.5 minimum version fix is used in CI builds.

* Update macOS workflow to include macOS 15 (#1806)

Co-authored-by: Cursor Agent <[email protected]>

* default: "macos-15"

* Fix flaky Rocky Linux 9 python3 detection in install-python-deps

Add PATH fallback to /usr/local/bin if python3 is not found in the
current PATH. This handles cases where the symlink exists but the
shell environment hasn't picked up the PATH changes yet.

Fixes intermittent 'python3: command not found' errors on both
x86 and arm64 Rocky Linux 9 builds.

* Add PATH export and verification for Rocky Linux 9 Python install

- Export PATH with /usr/local/bin to ensure python3 is found
- Add verification that /usr/bin/python3 symlink works
- This ensures Python is accessible in subsequent workflow steps

Addresses intermittent python3 detection issues in CI.

---------

Co-authored-by: Cursor Agent <[email protected]>

* Revert "adding cherry picking script (#1790)"

This reverts commit 593033e.

* Fix Rocky Linux 9 build issues: upgrade to Python 3.10 and resolve glibc conflicts

Comprehensive fix for Rocky Linux 9 build failures:

1. Upgrade Python 3.9.6 -> 3.10.13
   - Better stability and compatibility
   - Added --enable-optimizations for performance
   - Updated symlinks to python3.10 and pip3.10

2. Fix glibc version conflicts
   - Use --nobest flag for yum commands
   - Handles version mismatches between base system and repos
   - Resolves 'nothing provides glibc = X.X.X' errors

3. Fix flaky python3 detection
   - Unconditionally add /usr/local/bin to PATH
   - Removes unreliable conditional checks
   - Eliminates 'python3: command not found' errors

These changes resolve intermittent build failures on both x86 and arm64.

---------

Co-authored-by: Artsiom Kharuzhenka <[email protected]>
Co-authored-by: Gal Cohen <[email protected]>
Co-authored-by: Ozan Tezcan <[email protected]>
Co-authored-by: efeldblum <[email protected]>
Co-authored-by: Cursor Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants