Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PHPUnit 12.5 #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kukulich wants to merge 2 commits into
base: 6.69.x
Choose a base branch
from
Draft

PHPUnit 12.5 #1546

kukulich wants to merge 2 commits into from
+1,034 −1,159

Conversation

@kukulich
Copy link
Collaborator

@kukulich kukulich commented Jan 21, 2026

No description provided.

@kukulich kukulich added the dependencies Pull requests that update a dependency file label Jan 21, 2026
@Ocramius
Copy link
Member

Ocramius commented Jan 23, 2026 

5 tests triggered 1 PHP deprecation:

1) /home/runner/work/BetterReflection/BetterReflection/src/SourceLocator/SourceStubber/PhpStormStubs/CachingVisitor.php:217
Constant E_STRICT is deprecated since 8.4, the error level was removed

That seems like our problem 🤔

@kukulich
Copy link
Collaborator Author

kukulich commented Jan 23, 2026 •
edited
Loading

PhpStormStubsSourceStubber reads the constant value if the constant is available. Some constans change their value in different environment or different PHP versions, so stubs are not able to have the right constant value.

https://github.com/Roave/BetterReflection/blob/6.69.x/src/SourceLocator/SourceStubber/PhpStormStubs/CachingVisitor.php#L217

The error is silenced by @ but PHPUnit modifies error reporting. That's why the deprecated warnings were disabled in PHPUnit.

I don't know what's the best and nice solution how to solve it... :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kukulich @Ocramius